DISA_KECK ========= + Problem, but I fixed it - Problem that should be fixed ASAP (before review) > Internal problem that can wait until after review ? Maybe a problem, but maybe I'm missing something !!! Show stopper. No review unless it's fixed. catalog/ -------- + File names don't fit SBN conventions catinfo.txt + File names in this text do not match actual file names in the directory. 1867g1targ.cat + The explicit reference to an upcoming mission is not appropriate here. keckihost.cat + Typos corrected lwsinst.cat + Typos corrected - I think the braced list following "Data Format" will be fairly opaque to most people reading this file. Elaborate a bit - even if only to add "See below, under 'Data Acquisition'." - This statement: "The chop-nod technique is very effective at cancelling the background radiation" is an opinion and should not be in a catalog file unless there's evidence or a citable authority to back it up. - In the FITS NAXIS Definition list, it is not at all clear, or even guessable, what you mean by things like this: 3 Chop beams (2 when chopping, otherwise 1: 0 = chop off, 1 = chop on) What, exactly, would be equal to zero or one? And when chopping is on, what position does each hyperplane correspond to? ? Is "As:So" right? What's "So"? Is this, perhaps, the "Si:As" moderate- flux array mentioned later? BIG QUESTION: Did we use either of these software tools to generate the reduced data? If so we should say so. If not, we should explain why not. person.cat ? Have you gotten permission from these perople to publish their contact information? phi1cet.cat & betaandtarg.cat + RECORD_TYPE should never be used in catalog files. (No data file is referenced.) + LABEL_REVISION_NOTE may never be "NULL". + The keyword is "TARGET_DESC", not "TARGET_DESCRIPTION". Clealy lvtool was not run on this! data/filters/ ------------- docinfo.txt - These file names are not the file names in the directory. *.lbl + Non-sentence in DESCRIPTION fields end in periods. This tells me that no one has read them for grammar. That ticks me off. So stop it. + The same stupid typos show up in all files. Proof before reproducing, please. > The TABLE object NAME is inappropriate. It is too long and cannot be used as a variable name. ? Isn't it a little insulting to tell a scientists how to convert a normalized transmission into a percentage? data/raw/* ---------- ? Why do all these files names begin with "focus"? *.lbl > TARGET_HELIOCENTRIC_DISTANCE and TARGET_GEOCENTRIC_DISTANCE are not defined keywords. What is the preferred action on this? > The array NAME is a problem, since it cannot be used as a variable name. Use underscores instead of blanks. - "10.7", et al., is a lousy value for "FILTER_NAME". See the current list of standard values for appropriate names. Also note there is a CENTER_FILTER_WAVELENGTH keyword you might find useful. - If STOP_TIME is not equal to START_TIME + EXPOSURE_DURATION, there should be an explanation of why provided in a prominent place - like the data set description. data/reduced/* -------------- ? Why do all these files names begin with "focus"? *.lbl > TARGET_HELIOCENTRIC_DISTANCE and TARGET_GEOCENTRIC_DISTANCE are not defined keywords. What is the preferred action on this? > The array NAME is a problem, since it cannot be used as a variable name. Use underscores instead of blanks. - The IMAGE objects must have a UNIT associated with them, yes? If not, why are the data floating-point? - "10.7", et al., is a lousy value for "FILTER_NAME". See the current list of standard values for appropriate names. Also note there is a CENTER_FILTER_WAVELENGTH keyword you might find useful. - If STOP_TIME is not equal to START_TIME + EXPOSURE_DURATION, there should be an explanation of why provided in a prominent place - like the data set description. document/ --------- lws_add_fits.lbl + The DATA_SET_ID had two spaces appended on the end. - PRODUCT_NAME doesn't seem quite right. What about them? - DOCUMENT_NAME isn't a document name. This should be a title. lws_fits.lbl + The DATA_SET_ID had two spaces appended on the end. - DOCUMENT_NAME isn't a document name. This should be a title. lws_make_flat + The DATA_SET_ID had two spaces appended on the end. - DOCUMENT_NAME isn't a document name. This should be a title. obs_log.lbl + The DATA_SET_ID had two spaces appended on the end. - DOCUMENT_NAME isn't a document name. This should be a title. ? We couldn't put this in a nice table file? index/ ------ index.tab - The directory names begin with a "/". They must be relative to the volume root, not absolute. imageidx.tab + You may not use the INDEX_TABLE object for anything other than the index.tab file. - The directory names begin with a "/". They must be relative to the volume root, not absolute. ? Why is this file here.