DISA_0001 ========= ========= [root] ====== voldesc.cat - Removed references to data sets other than the IRAS Tempel 1 images - This is not a valid VOLUME_ID - This is not a valid VOLUME_SET_ID *** This data set should not have a VOLDESC.CAT file anyway. It should be set up to add to our online archives. calib ===== *** This directory contained the Focal Plane Array data set update. It was removed from this data set. catalog ======= catinfo.txt - Removed references to parts of the FPA data set imageds.cat - DATA_SET_TERSE_DESC is not a sentence and should not end in a period. - line 43ff: REFERENCE_KEY_ID values are not an adequate substitute for proper citations. - line 61ff: It is not appropriate to continue to refer to someone by full name unless the is the possibility of confusion with another party. "Russell Walker" should be "Walker" or "Dr. Walker" after the initial user of his full name. - And by the way, why is Russel Walker not credited as a data producer? - line 87: Bad use of the indirect personal pronoun. Should be "PDS recommends reading..." or "PDS recommends all users read...". - line 109: This reference is to a transient location. The document should be referenced by title and author. - line 131: There is an unmatched left parenthesis inside the bracket. - line 139: Looks like the indefinite article "A" is missing after the first full stop. - line 142ff: The sentence that begins on the end of this line is ungrammatical. - line 156: This reference is to a transient location. The document should be referenced by title and author. - line 156ff: Bad use of the indirect personal pronoun. Should be "PDS recommends reading..." or "PDS recommends all users read...". - line 164: What are "sets Survey Scans"? - line 178: This reference is to a transient location. The document should be referenced by title and author. - line 197ff: This section refers to data which are not part of the data set. It should be reworded to reference the other data set. - line 209: Bad spacing; "an" should be "and". - line 210: References to directories are inappropriate in DATA_SET catalog descriptions. - line 230: Bad grammar - line 232: Missing full stop (presumably). - line 239: This statement is almost certainly not true. - line 253: Too much space around the comma. - line 256: If this is an exact quote, the grammatic is rather bad and we should either fix it or paraphrase. Also, the title, author and date of the online document quoted should be indicated. - line 265: If you're going to mention the previous review, you should also mention that the dataset was rejected, and list the reasons why. The present review should also be mentioned. - line 282ff: The DATA_SET_REFERENCE_INFORMATION object should only be used once in a DATA_SET object. REFERENCE_KEY_ID should contain a list of all the appropriate values. insthost.cat - line 61: There is no "table below" to see. - line 73: The instrument host description may NOT reference a directory structure of any kind. - line 82: This "N/A" reference must be removed. - INSTRUMENT_HOST_REFERENCE_INFO should not be repeated. instrmnt.cat - LABEL_REVISION_NOTE refers to the file "INSTHOST.CAT", but this cannot be resolved - it is certainly not a unique file name in the PDS catalog, or even the local SBN catalog. - line 53-4: All of these commas are wrong. - line 63 (& 50): There is no need to repeat this statement twice. - line 72: "photon induced" should be hyphenated. - line 79: What is "(DC)" supposed to mean? - line 91: "wasbootstrapped" should be "was boot-strapped". - line 92: This comma is wrong. - line 110: What is "(BD)" supposed to mean? - line 111: What is "(IB)" supposed to mean? - line 126: Whay is "rsolution" in quotes? - There should be only a single INSTRUMENT_REFERENCE_INFO object. mission.cat - line 237: I'm not sure adding Tempel 1 to the target list is actually appropriate. Tempel 1 was not a target of the IRAS mission. It was serendipitously observed, which is a very different thing. None of the other serendipitous IRAS targets are listed here. - MISSION_REFERENCE_INFORMATION should be combined into a single list. ref.cat - line 20: This is an invalid REFERENCE_KEY_ID - line 43: This is an invalid REFERENCE_KEY_ID - line 104: This is an invalid REFERENCE_KEY_ID data/ao/images ============== *** The "images" subdirectory is pointless and should be removed. *.lbl - MEAN_OBSERVATION_TIME is not a valid keyword. OBSERVATION_TIME may be used for the midpoint of an observation. - Are START_TIME and STOP_TIME really known to 1/1000th of a second? - The LINE_DISPLAY_DIRECTION and SAMPLE_DISPLAY_DIRECTION are not consistent with standard FITS. Are they correct? - The MAXIMUM and MINIMUM values are given to substantially greater precision than the significant digits achievable with a 4-byte IEEE Real number. - In SAMPLING_PARAMETER_UNIT, "/PIXEL" should be removed. (It's redundant.) - The UNIT value is badly formatted ("W/cm**2/sr" is better, but note that UNIT values may be forced to upper case). - No keywords should ever follow the end of an object definition. The NOTE must be moved above the HEADER object. - Inside NOTE: SAMPLE_DISPLAY_DIRECTION and LINE_DISPLAY_DIRECTION have nothing to do with where North is located relative to the image. Plus, their values are suspect. What, if anything, is actually known about the direction of North? - Inside NOTE: Map projections should at least be indicated by a MAP_PROJECTION_TYPE keyword, preferably with a MAP_PROJECTION_DESC provided. Ideally the DATA_SET_MAP_PROJECTION and IMAGE_MAP_PROJECTION objects would also be provided with the data set. - Inside NOTE: Item 6 indicates there is a null value used which is not indicated by a MISSING_CONSTANT element in the IMAGE object definition. - In the FITS label I see this line: BLANK = 32767 / Value for empty cell What does this mean and how is it accounted for in the label? - Heliocentric distance, geocentric distance and phase angle are all in the FITS header and should be added to the data labels as well (new keywords have been proposed). - TARGET_CENTER_DISTANCE is being used incorrectly, assuming the FITS label is correct. Radiance labels: - What is this table inside the NOTE field?!? This does not belong in a label. It might belong in a separate data file, in a calibration file, or in a catalog file. data/survey/images ================== *** The "images" subdirectory is pointless and should be removed. *.lbl - MEAN_OBSERVATION_TIME is not a valid keyword. OBSERVATION_TIME may be used for the midpoint of an observation. - OBSERVATION_INCLINATION is not a valid keyword. - Are START_TIME and STOP_TIME really known to 1/1000th of a second? - The LINE_DISPLAY_DIRECTION and SAMPLE_DISPLAY_DIRECTION are not consistent with standard FITS. Are they correct? - In SAMPLING_PARAMETER_UNIT, "/PIXEL" should be removed. (It's redundant.) - The UNIT value is badly formatted ("W/cm**2/sr" is better, but note that UNIT values may be forced to upper case). - No keywords should ever follow the end of an object definition. The NOTE must be moved above the HEADER object. - Inside NOTE: SAMPLE_DISPLAY_DIRECTION and LINE_DISPLAY_DIRECTION have nothing to do with where North is located relative to the image. Plus, their values are suspect. What, if anything, is actually known about the direction of North? - Inside NOTE: Map projections should at least be indicated by a MAP_PROJECTION_TYPE keyword, preferably with a MAP_PROJECTION_DESC provided. Ideally the DATA_SET_MAP_PROJECTION and IMAGE_MAP_PROJECTION objects would also be provided with the data set. - Inside NOTE: Item 6 indicates there is a null value used which is not indicated by a MISSING_CONSTANT element in the IMAGE object definition. - TARGET_CENTER_DISTANCE is being used incorrectly, assuming the FITS label is correct. document ======== docinfo.txt - line 17,25: "Contain" should be "contains". - line 18,26,39: Files in these three formats cannot be "identical". They might be "equivalent". onlabel.txt - This file lists keywords which do not exist as though they do. document/ao =========== exp_supp_ao.lbl - The DOCUMENT_NAME should not begin with things like "PDF Version". It should be the title of the document, with versioning information appended. - Do we have copyright permission to re-publish this document? Does Vanguard Research own the copyright? document/archive_interface ========================== archive_interface_control.lbl - Who owns the copyright on this document? Do we have permission to republish? - The DOCUMENT_NAME should not begin with things like "PDF Version". It should be the title of the document, with versioning information appended. document/survey =============== exp_supp_survey.lbl - The DOCUMENT_NAME should not begin with things like "PDF Version". It should be the title of the document, with versioning information appended. - Do we have copyright permission to re-publish this document? Does Vanguard Research own the copyright? document/trail_images ===================== exp_supp_trail.lbl - The DOCUMENT_NAME should not begin with things like "PDF Version". It should be the title of the document, with versioning information appended. - Do we have copyright permission to re-publish this document? Does Vanguard Research own the copyright? *.jpg - The label provided is inadequte. There must be some documentation that gives some clue about the parameters for each image. A DOCUMENT label is not a particularly good way to present these images. index ===== index.lbl - TARGET_NAME appears twice. - The INDEX_TABLE object does not include the required PRODUCT_ID column. - STOP_TIME in the label is 1983-06-18T06:49:21.000, but the maximum STOP_TIME in the index table is 1983-10-08T00:17:00.000.