DISA_0001
=========
=========
> = comments by SAM
> N.B. DISA_0001 is the ID used for the review. The VOLUME_ID
for the archive is DISA_0003. For other DI volume ids, see
http://pdssbn.astro.umd.edu/internal/doc/DI_stuff/di_volume_ids.html
[root]
======
voldesc.cat
- Removed references to data sets other than the IRAS Tempel 1 images
- This is not a valid VOLUME_ID
- This is not a valid VOLUME_SET_ID
*** This data set should not have a VOLDESC.CAT file anyway. It should
be set up to add to our online archives.
> Actually, a voldesc.cat is now required. Corrected the VOLUME_ID and
VOLUME_SET_ID
calib
=====
*** This directory contained the Focal Plane Array data set update. It
was removed from this data set.
catalog
=======
catinfo.txt
- Removed references to parts of the FPA data set
imageds.cat
- DATA_SET_TERSE_DESC is not a sentence and should not end in a period.
> Corrected
- line 43ff: REFERENCE_KEY_ID values are not an adequate substitute for proper
citations.
> Corrected
- line 61ff: It is not appropriate to continue to refer to someone by full
name unless the is the possibility of confusion with another party.
"Russell Walker" should be "Walker" or "Dr. Walker" after the initial
user of his full name.
> Corrected
- And by the way, why is Russel Walker not credited as a data producer?
> Added as a data producer
- line 87: Bad use of the indirect personal pronoun. Should be "PDS
recommends reading..." or "PDS recommends all users read...".
> Corrected
- line 109: This reference is to a transient location. The document should
be referenced by title and author.
> Corrected
- line 131: There is an unmatched left parenthesis inside the bracket.
> Corrected
- line 139: Looks like the indefinite article "A" is missing after the first
full stop.
> Corrected
- line 142ff: The sentence that begins on the end of this line is
ungrammatical.
> Corrected
- line 156: This reference is to a transient location. The document should
be referenced by title and author.
> Corrected
- line 156ff: Bad use of the indirect personal pronoun. Should be "PDS
recommends reading..." or "PDS recommends all users read...".
> Corrected
- line 164: What are "sets Survey Scans"?
> Corrected
- line 178: This reference is to a transient location. The document should
be referenced by title and author.
> Corrected
- line 197ff: This section refers to data which are not part of the data set.
It should be reworded to reference the other data set.
> Corrected
- line 209: Bad spacing; "an" should be "and".
> Corrected
- line 210: References to directories are inappropriate in DATA_SET catalog
descriptions.
> Corrected
- line 230: Bad grammar
> Corrected
- line 232: Missing full stop (presumably).
> Corrected
- line 239: This statement is almost certainly not true.
> Corrected
- line 253: Too much space around the comma.
> Corrected
- line 256: If this is an exact quote, the grammatic is rather bad and we
should either fix it or paraphrase. Also, the title, author and date of
the online document quoted should be indicated.
> Replaced with a paraphrase
- line 265: If you're going to mention the previous review, you should also
mention that the dataset was rejected, and list the reasons why. The
present review should also be mentioned.
> Removed the reference to the previous review since the intent of that
review was to simply perform a first-look.
- line 282ff: The DATA_SET_REFERENCE_INFORMATION object should only be used
once in a DATA_SET object. REFERENCE_KEY_ID should contain a list of all
the appropriate values.
> Corrected
insthost.cat
- line 61: There is no "table below" to see.
> Table moved to instrmnt.cat; corrected this line
- line 73: The instrument host description may NOT reference a directory
structure of any kind.
> Corrected
- line 82: This "N/A" reference must be removed.
> Removed
- INSTRUMENT_HOST_REFERENCE_INFO should not be repeated.
> Replace with a list
instrmnt.cat
- LABEL_REVISION_NOTE refers to the file "INSTHOST.CAT", but this cannot
be resolved - it is certainly not a unique file name in the PDS catalog,
or even the local SBN catalog.
> Corrected
- line 53-4: All of these commas are wrong.
> Corrected
- line 63 (& 50): There is no need to repeat this statement twice.
> Corrected
- line 72: "photon induced" should be hyphenated.
> Corrected
- line 79: What is "(DC)" supposed to mean?
> Corrected
- line 91: "wasbootstrapped" should be "was boot-strapped".
> Corrected
- line 92: This comma is wrong.
> Corrected
- line 110: What is "(BD)" supposed to mean?
> Corrected
- line 111: What is "(IB)" supposed to mean?
> Corrected
- line 126: Whay is "rsolution" in quotes?
> Corrected
- There should be only a single INSTRUMENT_REFERENCE_INFO object.
> Corrected
mission.cat
- line 237: I'm not sure adding Tempel 1 to the target list is actually
appropriate. Tempel 1 was not a target of the IRAS mission. It was
serendipitously observed, which is a very different thing. None of
the other serendipitous IRAS targets are listed here.
> Removed Tempel 1 from the target list
- MISSION_REFERENCE_INFORMATION should be combined into a single list.
> Corrected
ref.cat
- line 20: This is an invalid REFERENCE_KEY_ID
> Corrected
- line 43: This is an invalid REFERENCE_KEY_ID
> Corrected
- line 104: This is an invalid REFERENCE_KEY_ID
> Did not change; ROWAN-ROBINSETAL1984 was already in the DD.
data/ao/images
==============
*** The "images" subdirectory is pointless and should be removed.
*.lbl
- MEAN_OBSERVATION_TIME is not a valid keyword. OBSERVATION_TIME
may be used for the midpoint of an observation.
> The definition of OBSERVATION_TIME is not correct for IRAS
observations. The MEAN_OBSERVATION_TIME keyword was defined
and submitted to CN shortly after the 2003 Comet Review
but is not yet in the DD. Sigh.
- Are START_TIME and STOP_TIME really known to 1/1000th of a second?
> These times were provided by the data producer.
- The LINE_DISPLAY_DIRECTION and SAMPLE_DISPLAY_DIRECTION are not
consistent with standard FITS. Are they correct?
> Yes, they were OK. But changed to the FITS standard (samples
RIGHT, lines DOWN). North is now toward the bottom of
the image when displayed.
- The MAXIMUM and MINIMUM values are given to substantially greater
precision than the significant digits achievable with a 4-byte
IEEE Real number.
> The values were simply pulled from the FITS headers generated
by the data producer.
- In SAMPLING_PARAMETER_UNIT, "/PIXEL" should be removed. (It's
redundant.)
> Corrected.
- The UNIT value is badly formatted ("W/cm**2/sr" is better, but note
that UNIT values may be forced to upper case).
> Corrected to "W/CM**2/SR"
- No keywords should ever follow the end of an object definition. The
NOTE must be moved above the HEADER object.
> Moved NOTE
- Inside NOTE: SAMPLE_DISPLAY_DIRECTION and LINE_DISPLAY_DIRECTION have
nothing to do with where North is located relative to the image.
Plus, their values are suspect. What, if anything, is actually known
about the direction of North?
> CRVALn, CRPIXn, CDELTn in the FITS headers the relation of RA and
DEC in the image: RA decreases as the sample index increases
and DEC increases as the line index increases. Therefore, if the
images are displayed with SAMPLE_DISPLAY_DIRECTION = "RIGHT" and
LINE_DISPLAY_DIRECTION = "UP", North is towards the top and
East is to the left of the image. And, per Casey's analysis,
the Sun is towards the upper left of the image.
- Inside NOTE: Map projections should at least be indicated by a
MAP_PROJECTION_TYPE keyword, preferably with a MAP_PROJECTION_DESC
provided. Ideally the DATA_SET_MAP_PROJECTION and IMAGE_MAP_PROJECTION
objects would also be provided with the data set.
> Inserted MAP_PROJECTION_TYPE into IMAGE object
- Inside NOTE: Item 6 indicates there is a null value used which is not
indicated by a MISSING_CONSTANT element in the IMAGE object definition.
> Inserted MISSING_CONSTANT into IMAGE object
- In the FITS label I see this line:
BLANK = 32767 / Value for empty cell
What does this mean and how is it accounted for in the label?
> The data producer provided this keyword. The value is not
used in the image array. However, the value of the NO_SCAN
keyword, -9999.00, is used in the images. The value
identifies pixels that are outside of the scan.
- Heliocentric distance, geocentric distance and phase angle are all in
the FITS header and should be added to the data labels as well (new
keywords have been proposed).
> Added
- TARGET_CENTER_DISTANCE is being used incorrectly, assuming the FITS
label is correct.
> Replaced with TARGET_GEOCENTRIC_DISTANCE
Radiance labels:
- What is this table inside the NOTE field?!? This does not belong in a
label. It might belong in a separate data file, in a calibration file,
or in a catalog file.
> Extracted the effective resolution table from the NOTE field and
placed into an ASCII table; see the new data/ao/effres subdirectory.
data/survey/images
==================
*** The "images" subdirectory is pointless and should be removed.
*.lbl
- MEAN_OBSERVATION_TIME is not a valid keyword. OBSERVATION_TIME
may be used for the midpoint of an observation.
> The definition of OBSERVATION_TIME is not correct for IRAS
observations. The MEAN_OBSERVATION_TIME keyword was defined
and was submitted to CN shortly after the 2003 Comet Review
but is not yet in the DD. Sigh.
- OBSERVATION_INCLINATION is not a valid keyword.
> The OBSERVATION_INCLINATION keyword was defined and submitted
to CN shortly after the 2003 Comet Review but is not yet in
the DD. Sigh.
- Are START_TIME and STOP_TIME really known to 1/1000th of a second?
> Corrected
- The LINE_DISPLAY_DIRECTION and SAMPLE_DISPLAY_DIRECTION are not
consistent with standard FITS. Are they correct?
> Yes, they were OK. But changed to the FITS standard (samples
RIGHT, lines DOWN). North is now toward the bottom of
the image when displayed.
- In SAMPLING_PARAMETER_UNIT, "/PIXEL" should be removed. (It's
redundant.)
> Corrected
- The UNIT value is badly formatted ("W/cm**2/sr" is better, but note
that UNIT values may be forced to upper case).
> Corrected to "W/CM**2/SR"
- No keywords should ever follow the end of an object definition. The
NOTE must be moved above the HEADER object.
> Moved
- Inside NOTE: SAMPLE_DISPLAY_DIRECTION and LINE_DISPLAY_DIRECTION have
nothing to do with where North is located relative to the image.
Plus, their values are suspect. What, if anything, is actually known
about the direction of North?
> Casey helped determine the orientation of survey scan data.
When one of these FITS images is displayed with
SAMPLE_DISPLAY_DIRECTION = "RIGHT" and LINE_DISPLAY_DIRECTION = "UP",
North is towards the bottom and East is to the right. Then, the
the direction to the Sun is towards the lower right corner.
These are the same display directions that Casey used for IRAS
images in a publication about the coma of Tempel 1.
- Inside NOTE: Map projections should at least be indicated by a
MAP_PROJECTION_TYPE keyword, preferably with a MAP_PROJECTION_DESC
provided. Ideally the DATA_SET_MAP_PROJECTION and IMAGE_MAP_PROJECTION
objects would also be provided with the data set.
> Not changed. One of IRAS' native coordinate system, solar
elongation and inclination of the observation wrt the ecliptic
plane, was used. Survey images were supposedly provided with the
same orientation as the pointed observations, with north toward
the bottom when displayed with samples increasing to the right and
lines increasing down.
- Inside NOTE: Item 6 indicates there is a null value used which is not
indicated by a MISSING_CONSTANT element in the IMAGE object definition.
> There is no such note in the survey scan labels!! And, there is
no missing constant value for the survey images.
- TARGET_CENTER_DISTANCE is being used incorrectly, assuming the FITS
label is correct.
> Replaced with TARGET_GEOCENTRIC_DISTANCE
document
========
docinfo.txt
- line 17,25: "Contain" should be "contains".
> Fixed
- line 18,26,39: Files in these three formats cannot be "identical".
They might be "equivalent".
> Fixed
onlabel.txt
- This file lists keywords which do not exist as though they do.
> Corrected
document/ao
===========
exp_supp_ao.lbl
- The DOCUMENT_NAME should not begin with things like "PDF Version". It
should be the title of the document, with versioning information appended.
> Corrected
- Do we have copyright permission to re-publish this document? Does
Vanguard Research own the copyright?
> Per Mike A'Hearn, Deep Impact paid the Russell Walker to produce
and deliver these data. Walker's document was not published.
document/archive_interface
==========================
archive_interface_control.lbl
- Who owns the copyright on this document? Do we have permission to
republish?
> ACT is a subcontractor to Deep Impact. The mission owns the
copyright. The AICD is not a published document.
- The DOCUMENT_NAME should not begin with things like "PDF Version". It
should be the title of the document, with versioning information appended.
- Corrected
document/survey
===============
exp_supp_survey.lbl
- The DOCUMENT_NAME should not begin with things like "PDF Version". It
should be the title of the document, with versioning information appended.
> Corrected
- Do we have copyright permission to re-publish this document? Does
Vanguard Research own the copyright?
> Per Mike A'Hearn, Deep Impact paid the Russell Walker to produce
and deliver these data. Walker's document was not published.
document/trail_images
=====================
exp_supp_trail.lbl
- The DOCUMENT_NAME should not begin with things like "PDF Version". It
should be the title of the document, with versioning information appended.
> Corrected
- Do we have copyright permission to re-publish this document? Does
Vanguard Research own the copyright?
> Per Mike A'Hearn, Deep Impact paid the Russell Walker to produce
and deliver these data. Walker's document was not published.
*.jpg
- The label provided is inadequte. There must be some documentation that
gives some clue about the parameters for each image. A DOCUMENT label
is not a particularly good way to present these images.
> During the preliminary review of this data set, we were instructed
NOT to include these images as data but include the images as
documentation for future reference. We do not have actual
observing dates in the raw image headers. I noted in the
document that dates are not available and provided other image
parameters that may be useful (plate number, HCON #s, RA, and DEC).
index
=====
index.lbl
- TARGET_NAME appears twice.
> Fixed
- The INDEX_TABLE object does not include the required PRODUCT_ID column.
> Included
- STOP_TIME in the label is 1983-06-18T06:49:21.000, but the maximum
STOP_TIME in the index table is 1983-10-08T00:17:00.000.
> Corrected
> Inserted VOLUME_ID and DATA_SET_ID for each record in index.tab