DIF-C-HRII-3/4-9P-ENCOUNTER-V3.0

Review Result: Certified.

Symbol Key:
  o = Lien open
  x = Lien resolved or closed
  ! = Lien rejected or declined
  + = Comments (by SMcLaughlin unless otherwise indicated)   

Catalog
=======
! In the dataset.cat file description, please add full citations to the
  Calibration papers (i.e., as footnotes in the text in addition to the 
  REFERENCE objects that also exist).
+ Rejected by PI and archive lead.  The correct and full citations are
  already in ref.cat. 
  
x In dataset.cat. the CITATION_DESC year must be '2014' since 
  this is when the data were reviewed and released to the public.
+ Done.  

x Please note in the dataset.cat Confidence Level Note that transient 
  anomalous pixels may be present in the data.
+ Done.
  
x In dataset.cat, the description of the east flip for lookback images 
  is incorrect. (In the paragraph beginning, "Using this convention for 
  Tempel 1 approach images...".)  See Jianyang's slide 17 for the 
  geometry and correct orientation.
+ Done.

x In dataset.cat 
  x The DATA_SET_TERSE_DESC says that the instrument was HRIV not HRII.
  x line 100: typo: Change "KLAASENTAL2005" to "KLAASENETAL2005".
+ Done.

x The required instrument_host catalog file is missing for the impactor.  
+ Rejected.  The impactor is not the host for this instrument, and was
  never required in the past.  This is a PDS validator bug. 
 
x In voldesc.cat:
  x This data set is NOT an amalgam of physical volumes, so the VOLUME_ID 
    must be valid - it may not end in 'X'.  
  x VOLUME_VERSION_ID must be set with respect to the final, valid VOLUME_ID.
+ Done.
 
[SAM: This lien was in the HRII Hartley2 list, but belongs here!]
x In dataset.cat, the description of the east flip for lookback images 
  is incorrect. (In the paragraph beginning, "Using this convention for 
  Tempel 1 approach images...".)  See Jianyang's slide 17 for the 
  geometry and correct orientation.
+ Done.
 
  
Documents
=========
x Ensure these data sets have the latest versions of these document files:
    day_of_year_calendar.lbl
    epoxi_cal_pipeline_summ.lbl
    epoxi_sis.lbl
    instruments_hampton.lbl
    pdsdd_epoxi.lbl
    quaternion_desc.lbl
+ Done. 
 
x In epoxi_sis.pdf:
  x This document says labels for HRIV, MRI, and ITS level 3/4 data, PDS keyword
    PROCESSING_HISTORY_TEXT contain
      FLAT_PRO=
      FLATCONS=
      FLATTEMP=
      CALWINDW=
      CALWINPY=
    but the sample labels in the SIS's 4.4.4.1 and 4.4.4.2 do not.
  x p. 27: "DIF-L-HRII-3_4-EPOXI-LUNAR-CALS-V1.0" should have a / not a _
    i.e.   "DIF-L-HRII-3/4-EPOXI-LUNAR-CALS-V1.0"
  x epoxy_sis.pdf pages 47-9 the figures are misaligned with the text.  This 
    needs to be corrected in every copy of the document in all data sets.
+ Done, except for the item about PROCESSING_HISTORY_TEXT. That PDS keyword
  will contain different processing keywords because the calibration pipeline 
  performs different steps for the VIS HRIV, MRI, and ITS CCDs and the IR
  spectrometer.  For example, the FITS header keywords FLAT_PRO, FLATCONS, 
  FLATTEMP, CALWINDW, & CALWINPY only apply to IR calibration, so those values
  are never included in PROCESSING_HISTORY_TEXT.  However, we noted this
  difference in the description of PROCESSING_HISTORY_TEXT in the SIS.
  For last item, had to print the Word file as a Postscript to force alignment
  of figure pieces with text, then distilled the Postscript to PDF/A.
    
x There are summary files with names like hriv_3_4_epoxi_garrad.pdf.  In at 
  least some of these labels in some data sets, the Julian Date field is 
  described as being in the form YYYYMMDD.  This needs to be fixed if it
  applies to this data set.
+ Done.
 
x In places that describe the file naming convention, there needs to be a 
  clear indication of which time (beginning, middle, end) is used for 
  creating the file name.
+ Not applicable. Mid-obs is used in the filenames and for grouping products 
  into DOY directories, and this is already called out in the EPOXI SIS and
  dataset.cat files! Please read the metadata and documentation.   
  
  
CALIB/
======
x In dark/hriir_050622_3_2_6002201000.lbl, SAMPLE_BITS = "32" should not have 
  quotes around the numeric value.
+ Done.
  
x In specmap/*lbl:
  AXIS_NAME = ("SAMPLES", "LINES", "MEASUREMENT") is legal, but
  "SAMPLE" and "LINE" (singular) are much more common.
+ Done.
 
x The files:
    abscalir/hriir_050112_16_3_999.lbl
    flat/hriir_050112_8_0_0.lbl
  are missing the required first line, PDS_VERSION_ID = PDS3
+ Done.
   
x The sunspec/ subdirectory is not listed in the calinfo.txt file, and
  must be.
+ Done.