DITV_0002 ========= voldesc.cat - This file is missing. errata.txt - If there are no errata, there should be no errata.txt file. DI Thermal Vac Data - General Liens: - The document set should include the requirements document for the instruments. - The Ball calibration plans need to be ITAR-cleared and added to the archive. - All the FITS files indicate an OBJECT of "ground_cal" which is not particularly helpful. Is it possible to put the experiment name (EXPRMNT) there instead? Please note this was only an IRAF issue. - In the mission.cat file, there are no units in the tables. - In the mission.cat file are "n/a" entries in the look-back phase table, which contradicts the text preceding that says all three instruments will continue to operate for 60 hours. Fix this inconsistency. - In inst_hriir.cat there are typos in the units of the overview tables. Also, the information here should be compared to that available on the instrument web site and edited/improved accordingly. - In inst_hriir.cat, move the data in text into tables as far as possible. - The catalog and info.txt files need to be proofed. This should be changed to avoid ambiguity. - HRIIR data needs a discussion of the manganen wire temperature correction for the focal plane array. - The general descriptions in the filter_*.lbl files do not apply equally to all filters. In particular, the "650 nm center and 700nm width" is clearly not true in at least three cases. - There are two different things called "templog", which is misleading. One name or the other should be changed (and the change propagated to info.txt and other documentation). [One is a temperature log, one is actually an IDL program.] - In catalog files, replace "principle" with "principal". - At the Deep Impact science team meeting on 13-14 September 2004, several members requested that the Science Data Center (SDC) modifiy all HRIIR image mode 6 FITS data from the thermal-vacuuum test by multiplying both the reset and data frames by negative one. Without this modification, the data frame must be subtracted from the reset frame to ensure the resulting image had positive data number. It is more intuitive to subract the reset frame from the data frame. However, Mike A'hearn and Stef McLaughlin prefer that the data remain in the original state as used by the science team for calibration analyses. calib/ ------ *.lbl - PRODUCT_NAME will be forced to upper case. - Is this DESCRIPTION sufficient? I don't understand the jargon. - Why does every filter number EXCEPT 9 have both a number and a color in the file name? - For that matter, why does every file name begin with "filter_"? filter_1_clear.tab and filter_6_clear.tab - Both labels say the filters are centered at 650 nm with a width over 700 nm. But the tables show wavelengths 200 to 1200 nm, all at 92%+ transmission filter_5_ir.tab - Label says the filter is centered at 950 with a width of 100 nm but transmission rises at 900 and stays level through 1200 nm. catalog/ -------- These files do not use SBN standard names. To do so would make it somewhat easier to make sure the same name is used everywhere. catinfo.txt - The dataset catalog file has a different name than the one mentioned in this file. dataset_tv2.cat - DATA_SET_NAME value is too long. - I thought all the calibration targets were just going to be "CALIBRATION". Why "GROUND CALIBRATION"? - CITATION_DESC may not be "NULL". - There is no attribution for the DATA_SET_DESC text. No anonymous text in DATA_SET objects! - REFERENCE_KEY_ID values may NOT be used in text descriptions instead of proper citations. (They may be used in addition to them.) - "Processing History" is blank. Either provide it or remove the heading. Is this file finished? - DATA_SET_HOST may not contain a multi-valued INSTRUMENT_ID. Provide separate DATA_SET_HOST object for each unique (INSTRUMENT_HOST_ID, INSTRUMENT_ID) pair. - The word fucus is misspelled on line 115, groundcal.cat - "CALIBRATION" is not a proper noun. TARGET_NAME should be something like "GROUND CALIBRATOR". - I think this DESCRIPTION may be too restrictive. hrivis.cat - This is a particularly bad name for this file. - "INSTRUMENT-INFO" (in the DATA_SET_ID) is not a good description for this dataset. - CITATION_DESC may not be "NULL". - Why is Don Hampton not credited in PRODUCER_FULL_NAME? insthost_flyby.cat - No attribution for the text, which I know I've read before, making it plagiarized. Attribute it or delete it. - RREFERENCE_KEY_IDs instead of citations. - Why does this object contain this sentence: "For further descriptions about the impactor..."? Impactor references are not relevant here. And descriptions are "of" something, not "about" something. inst_hriir.cat - Is it really necessary and desirable to include "DEEP IMPACT" in the INSTRUMENT_NAME? - REFERENCE_KEY_ID blah blah blah - The word demagnificationof is misspelled on line 47 inst_hrivis.cat - Is it really necessary and desirable to include "DEEP IMPACT" in the INSTRUMENT_NAME? - RREFERENCE_KEY_IDs instead of citations. - The word transmisssion is misspelled on line 37. - The word namometers is misspelled on line 43. mission.cat - RECORD_TYPE does not belong in catalog files. - REFERENCE_KEY_IDs without citations. - Check with Tyler on this, but I think that MISSION_HOST may not contain multi-valued keywords. It must be repeated once for each unique INSTRUMENT_HOST_ID. - Another check with Tyler: Should ALL targets (including the calibration target(s)) be included in the MISSION_TARGET list? ref.cat - RECORD_TYPE is inappropriate in catalog files. - Articles accepted but not yet printed are "in press," not "in publication." - There are line break problems in some of the references, which suggests that some fast cutting-and-pasting were done. Do all these references really end with the same line ("Space Science Reviews, submitted")? data/ ----- - Is it not possible to simplify these file names a bit? It looks to me like the first 8 bytes are redundant with the directory structure. hriir/ & hrivis/ *.lbl - STOP_TIME cannot be "N/A" if START_TIME is valid. It may be the same as the START_TIME (for an instantaneous observations), or it may be "UNK" or possibly "NULL," if you're planning to calculate it later on. - Labels should never contain filler values like "-9999.000". They must use the figurative constants "UNK," "N/A," or "NULL". - There is no unit on MINIMUM_WAVELENGTH and MAXIMUM_WAVELENGTH. Even if the default is appropriate, which is unlikely, it is not safe to assume. - A) How can HORIZONTAL/VERTICAL_PIXEL_SCALE be "N/A" in an image, and B) If they are, why are they in the label in the first place? - Why is there a PRODUCER_FULL_NAME credit in here but not a CITATION_DESC? templog/*lbl - The comment after START_TIME and STOP_TIME appears to be gibberish. document/ --------- docinfo.txt - Correct typos. - It is confusing terminology to talk about the "first thermal vac," which actually occurred during the second thermal vac run. This should be changed to avoid ambiguity. pdsdd/pdsdd_di.lbl - Spelling errors. - These descriptions (and those elsewhere that refer to this document) confuse the concepts of "local dictionary," "PDS Data Dictionary", and the hybrid that is actually present in this directory. This needs to be MUCH more clearly explained. - pdsdd_di.full apparently contains a modified form of the pdsdd.full file, BUT THERE IS NO NOTATION TO THAT EFFECT IN THE FILE HEADER. This is misleading and completely inappropriate. reports/ ------- - In reports directory, convert jpg files to png format? reports/reports.lbl - I find this description to be a bit sparse. The documents themselves seem to be colloquial, and perhaps culled from email messages. This should probably be explained. reports/summary.lbl - Spelling/grammar errors reports/report_20020819.asc - The word wavlength is misspelled on line 16 templog/ - There are IDL routines in the templog subdir under the document dir. Should these be in the software directory? templog/*.lbl - Grammar errors templog/temp_ext_hri.txt: - The word supecedes is misspelled on line 40 index/ ------ - Could these file names be any more confusing? - INDEX/ subdirectory file naming standards are being flagrantly ignored here. - This directory and its contents needs to be completely re-done according to standards. - In the index directory there are two files in the directory that are not listed in the info.txt file. (Content duplicates other files.) hrivis_index.lbl - Why is this file here? indxinfo.txt - Last two descriptions have the same file name. - There is a file missing from the file list (index_hrivis). index.lbl - The required "index.tab" file absolutely, positively MUST use the INDEX_TABLE object and use it properly. Other indices MUST have names other than "index.tab." - INSTRUMENT_NAME is spelled differently here than in the data files and (I think) the instrument catalog file.