DIF-CAL-MRI-2-EPOXI-CALIBRATIONS-V2.0
=====================================
 
 
Review Result: Passes pending minor lien resolution.  Certified.

 
Symbol Key:
  o = Lien open
  x = Lien resolved
  + = Comments (by SAM unless otherwise indicated) 
  
  
Liens
=====
x There is a table file in the document/directory listing all the data 
  files. It looks like an index file.  It should probably be in the index/ 
  directory, but some reviewers prefer it in the data or document directory.
  Please move it to the index/directory, but mention in the docinfo.txt 
  file that it exists.
    +  The science image parameter tables are considered documentation
       for EPOXI.  Reviewers for v1.0 and for EPOXI/EPOCh datasets
       perferred these files in DOCUMENT.  We will continue this
       practice for these EPOXI Hartley2 datasets.

x In the dataset.cat file, the summary table needs to have dates and 
  day-of-years checked.
  +  Checked the dates and DOY values.  No discrepancies.

x If possible, add the QE curve for the CCDs to the other documentation or 
  calibration information, as seems most appropriate.
  +  Not applicable to this dataset.  QE curves provided by KKlaasen and
     TFarnham were added to /calib/ of DIF-C-MRI-3/4-EPOXI-HARTLEY2-V1.0.
 
x In the document/ directory, the epoxy_sis.pdf file Table 1 lists some 
  dates as 2010 which should be 2011.  (What is the status of this in the 
  documentation set?)  Why are these critical documents that were supposedly 
  collected in the best version in the document set being duplicated in the 
  data set document/ subdirectories?  They should not be.
    +  Done.  Fixed epoxy_sis.pdf.  In the past reviewers liked the more
       relevant documents in /document/ of the EPOXI datasets.  We will
       continue that practice.

x In the data set document/ directories, epoxy_inflight_cal_summary.pdf
  file, there is a reference to "iCar" which, to start with, should be
  "i Car", and which needs to have the better-known HD number included each
  time that name is listed.  This file should not be in the data set
  document/ directories (it should be in the document collection).  
    +  Done.  Noted in the document that 'i Car' is designated as 
       'HD 79447' in the archived data products.  Also noted that 
       the date for the IR extended linearity cal is 2/5-6/2011 
       (not 2010). 

x In the quaternion description document, the terminology used to identify
  the elements (q0, q1, q2,q3) doesn't match the terminology used in the 
  FITS headers, which refer to "qA, qX, qY, qZ".
    +  This lien belongs to the quaternion.asc file DI&EPOXI Doc Set V3.0!
    +  Done.  Edited quaternion.asc in V3.0 Doc Set to include the
       corresponding FITS header keywords that capture the quaternion.
 
x catalog/mri.cat
  x Fix outdated wording (e.g., "after EPOCh...").
      +  Done.
      
x catalog/epoxi.cat 
  x Check frequency that is specified for the IR coma scans for 
    the paragraph about departure imaging E+12 to E+21 days.
      +  Done.  LFeaga provided cadences for E-18 hours to E+2 days and
         for E+12 to E+21 days.

x document/pdsdd_epoxi.ful
  document/pdsdd_epoxi.idx
  x Add "DEEP IMPACT/EPOXI DOCUMENT COLLECTION V3.0" 
    VOLUME_SET_NAME in pdsdd_epoxi.ful.  Then remake pdsdd_epoxi.idx.
      +  Solved lien by deleting the "V3.0" string from VOLUME_SET_NAME 
         in the voldesc.cat file in di-c-hrii_hriv_mri_its-6-doc-set-v3.0.

x All copies of /catalog/epoxi.cat
  Cruise 1, EPOCh Photometry Test:  "On 4-9 November 2007, EPOCh photometry
  tests were performed.   During these tests, the HRIV instrument observed
  a bright (V=9) visual binary star (HD 80607) for 12 continuous hours to
  check..."  However the images were unexpectedly offset by 29 microradian  
  (12.2 arcsec)."   Check this conversion.  I get 29 microradian = 6.0
  arcsec.  Which value is correct??
    +  Done.  The correct value of the unexpected offset was 59 microradian
       per an email from DDeming dated 28 Nov 2007.  Corrected that value
       in epoxi.cat.
 
x epoxi_sis.pdf
  x Page 27, table, last row, col 2: "...-MRIV-..." should be "...-MRI..."?
      +  Done.  Fixed the typo.
  x Section 4.5: the massive table does not have EPOXI:MAXIMUM,
    EPOXI:MINIMUM, EPOXI:MEDIAN, EPOXI:STANDARD_DEVIATION, which are in 
    examples earlier in the SIS and in labels such as
    dif-c-mri-3_4-epoxi-hartley2-v1.0/data/radrev/2010/248/mv10090513_4000000_001_rr.lbl
      +  Done.  Added keywords; have same definition as the "derived"
         keywords (e.g. EPOXI:DERIVED_MINIMUM).

x Very minor, so not really a lien, but we should keep the text but remove
  the yellow highlighting in the HRIIR limitations section of the supporting
  document file: hartley2_cal_pipeline_summ.pdf.  This file is in many of the 
  data sets.  The highlighted text was there when LFeaga wrote it to get
  agreement from the team that those were the correct values.  We do not
  need or want to make that stand out in the archive, so the highlighting
  should be removed.
    + Done.

x Voldesc.cat needs to have VERSION_ID = 2.
    +  Done.
    
x In catalog/dataset.cat - HRII Radiometric Cal #2 (Beta Hyi):  "From 03-17 May 2010, 
  the HRII HRII spectrometer repeatedly..."   Get rid of one HRII.
    +  Done.
    
x In catalog/dataset.cat - Darks for E-34 Days to E+12 Days:  "The imaging sequences 
  that were ... background and stripe remova analyses."  remova => removal
    +  Done.
    
x In catalog/dataset.cat:   Data Set Overview, Instrument Checkout, first 
  line:  "On 4 October the three science instruments..."  Add year, 
  presumably 2007.
    +  Done.