DIF-C-ITS-3/4-9P-ENCOUNTER-V3.0

Review Result: Certified.

Symbol Key:
  o = Lien open
  x = Lien resolved or closed
  ! = Lien rejected or declined
  + = Comments (by SMcLaughlin unless otherwise indicated)   

Catalog
=======
! In the dataset.cat file description, please add full citations to the
  Calibration papers (i.e., as footnotes in the text in addition to the 
  REFERENCE objects that also exist).
+ Rejected by PI and archive lead.  The correct and full citations are
  already in ref.cat. 

x In dataset.cat: 
  x The CITATION_DESC year must be '2014' since this is when the data were 
    reviewed and released to the public.
  x Change "KLAASENTAL2005" to "KLAASENETAL2005".
  x Line 302: on-board "impactor" spacecraft
  x Line 517: type: Belton et al. (2011) (typo)
+ Done.

! The required instrument host catalog file is missing.
+ Rejected.  The flyby spacecraft is not the host for this instrument, and 
  was never required in the past.  This is a PDS validator bug? 


Documents
=========
x Ensure these data sets have the latest versions of these document files:
    day_of_year_calendar.lbl
    epoxi_cal_pipeline_summ.lbl
    epoxi_sis.lbl
    instruments_hampton.lbl
    pdsdd_epoxi.lbl
    quaternion_desc.lbl
+ Done. 
 
x In epoxi_sis.pdf:
  x This document says labels for HRIV, MRI, and ITS level 3/4 data, PDS keyword
    PROCESSING_HISTORY_TEXT contain
      FLAT_PRO=
      FLATCONS=
      FLATTEMP=
      CALWINDW=
      CALWINPY=
    but the sample labels in the SIS's 4.4.4.1 and 4.4.4.2 do not.
  x p. 27: "DIF-L-HRII-3_4-EPOXI-LUNAR-CALS-V1.0" should have a / not a _
    i.e.   "DIF-L-HRII-3/4-EPOXI-LUNAR-CALS-V1.0"
  x epoxy_sis.pdf pages 47-9 the figures are misaligned with the text.  This 
    needs to be corrected in every copy of the document in all data sets.
+ Done, except for the item about PROCESSING_HISTORY_TEXT. That PDS keyword
  will contain different processing keywords because the calibration pipeline 
  performs different steps for the VIS HRIV, MRI, and ITS CCDs and the IR
  spectrometer.  For example, the FITS header keywords FLAT_PRO, FLATCONS, 
  FLATTEMP, CALWINDW, & CALWINPY only apply to IR calibration, so those values
  are never included in PROCESSING_HISTORY_TEXT.  However, we noted this
  difference in the description of PROCESSING_HISTORY_TEXT in the SIS.
  For last item, had to print the Word file as a Postscript to force alignment
  of figure pieces with text, then distilled the Postscript to PDF/A.
     
x There are summary files with names like hriv_3_4_epoxi_garrad.pdf.  In at 
  least some of these labels in some data sets, the Julian Date field is 
  described as being in the form YYYYMMDD.  This needs to be fixed if it
  applies to this data set.
+ Done.
 
x In places that describe the file naming convention, there needs to be a 
  clear indication of which time (beginning, middle, end) is used for 
  creating the file name.
+ Not applicable. Mid-obs is used in the filenames and for grouping products 
  into DOY directories, and this is already called out in the EPOXI SIS and
  dataset.cat files! Please read the metadata and documentation. 
  
! In its_encounter_data_summary.pdf, there doesn't seem to be a good 
  correspondence between frames flagged in this file as problematic, and 
  what was included or omitted from the data set.  This list should be 
  reconciled with what's in the present data set, and an indication of 
  what was left out here that was included in previous versions should 
  be added if possible.  
+ Rejected.  The order of the images listed in the logs is taken from
  the sequence planning and include calibration frames such as darks
  which were intentionally not included in the calibrated datasets
  for Tempel1.  Calibration frames are available in the raw datasets as
  noted in dataset.cat and the SIS.  


CALIB/
======
x badpix/itsvis_050409_2_2_999.lbl
  typo: INSTRUMENT_NAME = "DEEP IMPACT IMPACTOR TARGETING SENSOR - VISIBLE
  CCD"w
+ Done.

x badpix/itsvis_050409_2_4_999.lbl and badpix/itsvis_050409_2_8_999.lbl:
  "SAMPLE_BITS" = "8" should not have quotes around the number.
+ Done.

x drkmodel/*.lbl:
  AXIS_NAME = ("SAMPLES", "LINES", "CURRENT_COEFFICIENTS") is legal, but
  "SAMPLE" and "LINE" (singular) are much more common.
+ Done.


DATA/
=====
x In the images right before impact, where the size switches to 64x64, 
  investigate/validate the signal-to-noise values.  This is in reponse 
  to Yan F.’s question about SNR value fluctuations in these images 
  verses earlier images.
+ Done. B.Carcich and K.Klaasen confirmed this is reasonable. It is documented
  in the new Appendix A to the EPOXI Cal Pipeline Summary document.
  
x Either remove DESTRIPE extension in the FITS files, or note in the 
  dataset.cat that all values in it are set to 0 because this step is 
  not applied to ITS images.
+ N.B. - This is already noted in Sec. 2.4 VIS Stripes Removal in the
  EPOXI Calibration Pipeline Summary report found in the document
  directories of calibrated DI and EPOXI datasets (i.e., if destriping was
  not applied, then all values in the DESTRIPE extension are set to 0.)
  However, added this clause to dataset.cat for ITS.