======================
SWAP Data Volumes
Delivered Dec 19, 2007
======================

$ = SBN fixed this item in the Dec 19 2007 delivery

===================
New items
===================

calib/rpa_shape.lbl
$ Table has 761 records but FILE_RECORDS and ROWS are set to 760 in the
  label. 

calib/background_009_dac.lbl
calib/esa_shape.lbl
calib/fov_mask_2d.lbl
calib/list_energy_files.lbl
calib/rpa_shape.lbl
$ The syntax is invalid for the value of the ^TABLE pointer.  If the
  table filename is inside paranetheses then a starting record or
  byte number just be included.  Lvtool and Vtool do not catch
  this syntax error byt pdstv throws a segmentation fault.  
  Chapter 14 in the PDS Standards presents the correct formats
  for OBJECT pointers. 

document/nh_trajectory.lbl
$ Replaced value of "N/A" for DATA_SET_ID with a list of the
  data set IDs for this data delivery.

document/quat_axyz_j2k_to_instr.lbl
$ Removed the REX V1.0 data sets from the list for DATA_SET_ID because
  these were rejected during the peer review.  NH plans to rework the
  REX data sets for the future V2.0 delivery.

dataset.cat
$ Changed ARCHIVE_STATUS from "IN LIEN RESOLUTION" to "LOCALLY ARCHIVED." 
$ Added label revision note for items SBN fixed.


======================
SWAP Data Volumes
Delivered Oct 29, 2007
======================

$ = SBN fixed this item in the Dec 19 2007 delivery
# = NH team fixed this lien in the Dec 19 2007 delivery
- = Still an outstanding lien or item

===================
General - New items
===================

calib/calinfo.txt
# Typos:
  line 12:  "Documentat" -> "Document"

catalog/dataset.cat
# TARGET_NAME in DATA_SET_TARGET object is set to "N/A".
  Change to the value(s) used in TARGET_NAME in the DATA labels,
  that is "SOLAR WIND".



==============================================================
General - Outstanding items from the early October delivery
==============================================================

aareadme.txt
$ Add entries for the SWAP_CAL document.

calib/background_009_dac.lbl & .tab
$ This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  This can occur when there
  is a mismatch between the value for the FORMAT keyword and how 
  values are formatted in that column in the table.  The wrong value
  for START_BYTE, BYTES, or DATA_TYPE can also cause this problem.  
  However, the everything appears to be OK.  Please take a look and 
  see if there is some mismatch we missed!

calib/esa_shape.lbl & .tab
$ This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  This can occur when there
  is a mismatch between the value for the FORMAT keyword and how 
  values are formatted in that column in the table.  The wrong value
  for START_BYTE, BYTES, or DATA_TYPE can also cause this problem.  

calib/fov_mask_2d.lbl & .tab
$ This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  This can occur when there
  is a mismatch between the value for the FORMAT keyword and how 
  values are formatted in that column in the table.  The wrong value
  for START_BYTE, BYTES, or DATA_TYPE can also cause this problem.  

calib/list_energy_files.lbl & .tab
$ This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  This can occur when there
  is a mismatch between the value for the FORMAT keyword and how 
  values are formatted in that column in the table.  The wrong value
  for START_BYTE, BYTES, or DATA_TYPE can also cause this problem.  

calib/rpa_shape.lbl & tab
$ This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  This can occur when there
  is a mismatch between the value for the FORMAT keyword and how 
  values are formatted in that column in the table.  The wrong value
  for START_BYTE, BYTES, or DATA_TYPE can also cause this problem.  

catalog/swap.cat
@ Typos:
  line  95:  "conccrent" -> "concurrent"
  line  95:  "houskeeping" -> "housekeeping" 

data/*lbl
- For the STATUS extensions, must the packet information for each 
  column be repeated in each label?  Is this information meaninful to 
  the end user? 

document/docinfo.txt
@ Typos:
  line  54:  MEHODOLOGY -> METHODOLOGY
  line  77:  GOUND TESTING -> GROUND TESTING
 
document/swap_ssr_images/swap_ssr_images.lbl
- The comment records are misleading because they imply this label is
  for a data file.  Remove the comment cards.

===============================================================
nhjusw_1001 - Outstanding items from the early October delivery
===============================================================

index/index.lbl & index.tab
@ INDEX.LBL states 
    START_TIME = 2007-01-07T14:04:49.882  
    STOP_TIME  = 2007-06-20T06:05:53.917
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2007-01-07T11:04:34.382
    STOP_TIME  = 2007-06-20T18:03:45.417
  Where did the values for label come from?

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!


===============================================================
nhjusw_2001 - Outstanding items from the early October delivery
===============================================================

index/index.lbl & index.tab
@ INDEX.LBL states 
    START_TIME = 2007-01-07T14:04:49.882
    STOP_TIME  = 2007-06-20T06:05:53.917
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2007-01-07T11:04:34.382
    STOP_TIME  = 2007-06-20T18:03:45.417
  Where did the values for label come from?

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!


===============================================================
nhlasw_1001 - Outstanding items from the early October delivery
===============================================================

catalog/dataset.cat
@ Typos:
  line  57:  "occured" -> "occurred"


===============================================================
nhlasw_2001 - Outstanding items from the early October delivery
===============================================================

catalog/dataset.cat
@ Typos:
  line  57:  "occured" -> "occurred"

index/index.lbl & index.tab
@ INDEX.LBL states:
    START_TIME = 2006-02-27T17:26:58.328
    STOP_TIME  = 2006-12-10T04:06:25.880
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2006-02-27T17:00:50.328
    STOP_TIME  = 2006-12-10T04:11:45.380
  Where did the values for label come from?

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!





=============================================================================
=============================================================================
Items from the early October delivery are included below.  They are included
here only as reference.
=============================================================================
=============================================================================

Bullet Key
x = Item was implemented or closed
- = Item was not implemented or is still open.
+ = Comment


=====================
General (all volumes)
=====================

Targets
x How would one find the SWAP data if the target is "N/A"?  Does NH plan 
  to use this value for the entire mission?  For the commissioning and cruise
  phases, it may be appropriate to use "CALIBRATION" if the instrument was not
  really pointing at a target.  Or would another target such as "SOLAR WIND", 
  "DUST", or "JUPITER" be appropriate?  "N/A" is useless.
  + Using "SOLAR WIND" in the DATA labels.

All aareadme.txt, info.txt, and catalog files
x Please run us through a spell checker.
  + This appears to have been done.

All info.txt files
x RECORD_TYPE has inconsistent values across these files.  Both STREAM and
  FIXED_LENGTH are used.  For example, calib/calinfo.txt used FIXED_LENGTH
  but document/docinfo.txt uses STREAM.

aareadme.txt
x Typos:
  line  85:  MEHODOLOGY -> METHODOLOGY
  line 108:  GOUND TESTING -> GROUND TESTING
  line 441:  Sytem -> System
  line 483:  obvserving -> observing
  line 655:  keywor/value -> keyword/value
  line 789:  correspoding -> corresponding
  line 853:  colunm -> column
  line 860:  thsi -> this
- Add entries for the SWAP_CAL document.
  + Not implemented yet.
x Add an entry for the NH_SWAP_V110_TI.TXT SPICE kernel to the
  DOCUMENT section of this file.  

voldesc.cat
x The TARGET_CATALOG pointer has a keyword value of "N_A.CAT" which
  implies there is a catalog file named "N_A.CAT".  However, this 
  file does not exist in /catalog/.  If there is no target then 
  simply set the TARGET_CATALOG pointer to "N/A".  
x Actually, what should the target be for the SWAP data sets?
 
catalog/catinfo.txt
x There is no file named "INSTR.CAT".  Change it to "SWAP.CAT". 

catalog/*.cat
x REFERENCE_KEY_IDs at the end of the catalog files must be defined
  in the ref.cat file.

catalog/swap.cat
- Typos:
  line  95:  "conccrent" -> "concurrent"
  line  95:  "houskeeping" -> "housekeeping" 
  + Not implemented yet.

data/*lbl
x TARGET_NAME should not be "N/A".
  + Changed to "SOLAR WIND"
x Please read the definition for the QUATERNION_DESC object.
  This element is a *POINTER* to an accompanying document that
  describes the type of quaternion being used.  Why is the
  quaternion described in each data label?  This information 
  should really be extracted into a document!
x Must the packet information for each column be repeated in each label?
  Is this information meaninful to the end user?  Consider moving this 
  information to a separate document unless it more useful for the user
  to see it in the label. 

document/docinfo.txt
- Typos:
  line  54:  MEHODOLOGY -> METHODOLOGY
  line  77:  GOUND TESTING -> GROUND TESTING
  + Not implemented yet.

document/samples/*asc
x Why are BSCAL/TSCAL and BZERO/TZERO being ignored?  The purpose of the
  samples is to show the expected data values, correct?  For example,
  when the SWAP extensions are displayed in "fv", all of the values 
  are positive because this tool applies zero-point values and scaling 
  factors.  Yet, most of the values in the samples are negative.  At first 
  glance, it seems the sample files provide the wrong data values.  
  + OK.  The sample files state scaling factors and offsets were not
    applied.
x Where are the files swa_0044668800_0x584_sci_1.fit and 
  swa_0044668800_0x584_sci_1.fit?  They are not on any of the SWAP volumes!
  Could not verify the swa_0011842464_586_e_1_*.asc and 
  swa_0011842464_586_s_1_*.asc files.
  + Ok. The file is in the Oct 29th version of the nhlasw_2001 volume.
x It's very hard to locate a FITS data file that is given on the FILENAME
  line in a sample.  Consider providing the **PDS volume** path instead
  of the SOC path. 
  + The sample files now include the path to the data file.  Good!

document/nh_swap_v110_ti.txt
x Why is this file here?  Is NH delivering a SPICE data set?
  + NH elected to keep this SPICE kernel here.  Yes, NH delivered
    a SPICE data set.

document/swap_ssr_images/swap_ssr_images.lbl
x Parentheses indicate an ordered set of values.  Use brackets {} for
  an unordered set of values (i.e., the order of the items is not
  signficant).  See Chapter 12 (ODL) in the PDS Standards Reference.
x The ^IMAGE pointers have no objects in the label.  All IMAGE pointers
  should be replaced with one PNG_DOCUMENT pointer set to an unordered 
  list of PNG file names:
    ^PNG_DOCUMENT = { "swap_ssr_equation1.png",
                      ...
                      "swap_ssr_t able7.png" }    
x DATA_SET_ID should be set to the ID for this data set.
x PRODUCT_ID is not required for documents.
  + Still in the labels.  OK to keep.
- The comment records are misleading because they imply this label is
  for a data file.  Remove the comment cards.
  + Not implemented yet.


===========
nhjusw_1001
===========

index/index.lbl & index.tab
- INDEX.LBL states 
    START_TIME = 2007-01-07T14:04:49.882  
    STOP_TIME  = 2007-06-20T06:05:53.917
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2007-01-07T11:04:34.382
    STOP_TIME  = 2007-06-20T18:03:45.417
  Where did the values for label come from?
  + Not implemented yet.

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!

index/cumindex.tab & cumindex.lbl
x Same problem as index.lbl & index.tab.
  + Change was implemented here but not in index.lbl!


===========
nhjusw_2001
===========

calib/*lbl
x The filename value for TABLE should be upper-case.
x The filename value for PRODUCT_ID should probably be upper-case, too.

calib/calinfo.txt
x Change RECORD_TYPE to STREAM;  

calib/background_009_dac_jup.lbl & .tab
calib/background_009_dac.lbl & .tab
x The labels do not correctly define the table layouts.  The FORMAT 
  keyword needs to be inserted into each COLUMN object. For example, 
  FORMAT = F6.4.  Also, several columns appear to incorrectly define
  the table layouts:  For example: 
   Record 1, Column 1 (ENERGY): Not a valid real number.
   Record 1, Column 2 (ESA_DAC): Not a valid integer.
   Record 1, Column 3 (RPA_DAC): Not a valid integer.
   Record 1, Column 4 (PCEM_BACK): Not a valid integer.
   Record 2, Column 1 (ENERGY): Not a valid real number.
   Record 2, Column 2 (ESA_DAC): Not a valid integer.
   Record 2, Column 3 (RPA_DAC): Not a valid integer.
   Record 3, Column 1 (ENERGY): Not a valid real number.
   Record 3, Column 2 (ESA_DAC): Not a valid integer.
   Record 3, Column 3 (RPA_DAC): Not a valid integer.
   Record 3, Column 4 (PCEM_BACK): Not a valid integer.
   Record 4, Column 6 (COIN_BACK): Not a valid integer.
   Record 5, Column 6 (COIN_BACK): Not a valid integer.
  + Labels and tables were changed.  However, pdstv now throws
    a segmentation fault for calib/background_009_dac.lbl & .tab. 

calib/esa_rpa_v19_energy_binsf.lbl & .tab
x The labels do not correctly define the table layouts.  The FORMAT 
  keyword needs to be inserted into each COLUMN object. For example, 
  FORMAT = F6.4.  Also, several columns appear to incorrectly define
  the table layouts:  For example: 
   Record 1, Column 1 (PLAN): Not a valid integer.
   Record 1, Column 2 (SWEEP): Not a valid integer.
   Record 1, Column 3 (ESA_DAC): Not a valid integer.
   Record 1, Column 4 (RPA_DAC): Not a valid integer.
   Record 1, Column 5 (VESA): Not a valid real number.
   Record 1, Column 6 (VRPA): Not a valid real number.
   Record 2, Column 1 (PLAN): Not a valid integer.
   Record 2, Column 2 (SWEEP): Not a valid integer.
   Record 2, Column 3 (ESA_DAC): Not a valid integer.
   Record 2, Column 4 (RPA_DAC): Not a valid integer.
   Record 2, Column 5 (VESA): Not a valid real number.
   Record 2, Column 6 (VRPA): Not a valid real number.
   Record 3, Column 1 (PLAN): Not a valid integer.
   Record 3, Column 2 (SWEEP): Not a valid integer.
      10 of these errors have been flagged.  No more will be reported.
   Record 3, Column 5 (VESA): Not a valid real number.
   Record 4, Column 5 (VESA): Not a valid real number.
   Record 4, Column 6 (VRPA): Not a valid real number.
   Record 4, Column 7 (CROSSING): Not a valid real number.
   Record 4, Column 8 (EPEAK): Not a valid real number.
   Record 4, Column 9 (WIDTH): Not a valid real number.
      10 of these errors have been flagged.  No more will be reported.

calib/esa_shape.lbl & .tab
- This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  For Column 2, it appears
  the value for FORMAT should be "F13.11" and not "F15.11".
  + Still getting a segmentation fault.  

calib/fov_mask_2d.lbl & .tab
- This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  Please verify the values
  for the following keywords for **every** column:
    START_BYTE
    BYTES
    DATA_TYPE
    FORMAT
  + Still getting a segmentation fault.  
 
calib/list_energy_files.lbl & .tab
x The labels do not correctly define the table layouts.  The FORMAT 
  keyword needs to be inserted into each COLUMN object. For example, 
  FORMAT = F6.4.  Also, several columns appear to incorrectly define
  the table layouts:  For example: 
   Record 1, Column 1 (NUMBER_OF_POINTS): Not a valid integer.
   Record 1, Column 2 (MET_START): Not a valid integer.
   Record 1, Column 3 (MET_STOP): Not a valid integer.
   Record 2, Column 1 (NUMBER_OF_POINTS): Not a valid integer.
   Record 2, Column 2 (MET_START): Not a valid integer.
   Record 2, Column 3 (MET_STOP): Not a valid integer.
   Record 3, Column 1 (NUMBER_OF_POINTS): Not a valid integer.
   Record 3, Column 2 (MET_START): Not a valid integer.
   Record 3, Column 3 (MET_STOP): Not a valid integer.
  + Labels and tables were changed.  However, pdstv now throws
    a segmentation fault. 

calib/rpa_shape.lbl & tab
- This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  Please verify the values
  for the following keywords for **every** column:
    START_BYTE
    BYTES
    DATA_TYPE
    FORMAT
  + Still getting a segmentation fault.  

index/index.lbl & index.tab
- INDEX.LBL states 
    START_TIME = 2007-01-07T14:04:49.882
    STOP_TIME  = 2007-06-20T06:05:53.917
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2007-01-07T11:04:34.382
    STOP_TIME  = 2007-06-20T18:03:45.417
  Where did the values for label come from?
  + Not implemented yet.

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!

index/cumindex.tab & cumindex.lbl
x Same problem as index.lbl & index.tab.
  + Change was implemented here but not in index.lbl!

===========
nhlasw_1001
===========

catalog/dataset.cat
- Typos:
  line  57:  "occured" -> "occurred"
  + Not implemented yet.

index/index.lbl & index.tab
x INDEX.LBL states:
    START_TIME = 2006-02-27T17:26:58.328
    STOP_TIME  = 2006-12-10T04:06:25.880
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2006-02-27T17:00:50.328
    STOP_TIME  = 2006-12-10T04:11:45.380
  Where did the values for label come from?

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!

index/cumindex.tab & cumindex.lbl
x Same problem as index.lbl & index.tab.


===========
nhlasw_2001
===========

calib/*lbl
x See nhjusw_2001.

calib/calinfo.txt
x See nhjusw_2001.

catalog/dataset.cat
- Typos:
  line  57:  "occured" -> "occurred"

calib/background_009_dac_jup.lbl & .tab
x See nhjusw_2001.

calib/background_009_dac.lbl & .tab
- See nhjusw_2001.
  + Segmentation fault

calib/esa_rpa_v19_energy_binsf.lbl & .tab
x See nhjusw_2001.

calib/esa_shape.lbl & .tab
- This label and table combination causes our SBN table verifier tool
  "pdstv" to produce a segmentation fault.  For Column 2, it appears
  the value for FORMAT should be "F13.11" and not "F15.11".
  + Segmentation fault
  
calib/fov_mask_2d.lbl & .tab
- See nhjusw_2001.
  + Segmentation fault
 
calib/list_energy_files.lbl & .tab
- See nhjusw_2001.
  + Segmentation fault

calib/rpa_shape.lbl & tab
- See nhjusw_2001.
  + Segmentation fault

index/index.lbl & index.tab
- INDEX.LBL states:
    START_TIME = 2006-02-27T17:26:58.328
    STOP_TIME  = 2006-12-10T04:06:25.880
  yet the minimum start time and maximum stop time in INDEX.TAB are:
    START_TIME = 2006-02-27T17:00:50.328
    STOP_TIME  = 2006-12-10T04:11:45.380
  Where did the values for label come from?
  + Not implemented yet.

  Actually if values for the START_ and STOP_TIME columns was pulled
  directly from the data labels, then you're welcome to remove 
  START_TIME and STOP_TIME kewyords from the index label file!

index/cumindex.tab & cumindex.lbl
x Same problem as index.lbl & index.tab.
  + Implemented only for cumindex.lbl/tab.